Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1546] update promo card content margin #1012

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 29, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1546

What I did

  • Update promo card content margin as per feedback: "Spacing should be consistent across all promo cards across all breakpoints. Token that should be used is rpl-sp-3 (12px) promo cards ONLY"

How to test

  • See storybook

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jan 29, 2024
Copy link

cypress bot commented Jan 29, 2024

Passing run #1189 ↗︎

0 118 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-core): update promo card content margin
Project: ripple-framework Commit: 6d135f62a4
Status: Passed Duration: 06:28 💡
Started: Jan 29, 2024 12:38 AM Ended: Jan 29, 2024 12:45 AM

Review all test suite changes for PR #1012 ↗︎

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 6d135f6
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65b6f4bdeb1638000812cfcf

@lambry lambry added this pull request to the merge queue Jan 29, 2024
Merged via the queue into develop with commit 9654bbf Jan 29, 2024
16 checks passed
@lambry lambry deleted the bugfix/R20-1546-promo-spacing branch January 29, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants