Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1719]: stop search firing when clearing filters without change #1013

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 29, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1719

What I did

  • This update stops a search taking place even when the filters haven't changed
  • This also means we're resetting filters back to the initial URL now (i.e. no query params)

How to test

  • Go to any current search listing (https://www.vic.gov.au/family-violence-recommendations/) and click clear filters, this fires off a search even though nothing has changed (from a users point of view). Contrast that to this PR and you should see the same action won't trigger an unneeded search.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

…l filters haven't changed

this also means we're resetting back to the initial URL now
@lambry lambry self-assigned this Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 959e15a
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65b72e1776e36100089c589a

@lambry lambry added this pull request to the merge queue Jan 30, 2024
Merged via the queue into develop with commit 937f5b9 Jan 30, 2024
8 checks passed
@lambry lambry deleted the bugfix/R20-1719-view-search-results-re-firing branch January 30, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants