Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1742] add support for content 'before' results #1014

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 29, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1742

What I did

  • add support for displaying content 'before' results (exactly the same as the afterResults section)

NOTE: this is a a draft for now, just waiting on the BE to give the A OK on the field name: field_above_results_content, ref: https://digital-vic.atlassian.net/browse/R20-1742?focusedCommentId=320770

Update: there's a PR branch for testing the backend which uses our field name field_above_results_content: https://nginx-php.pr-366.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/site-8888/test-above-content

Screenshot 2024-02-09 at 4 42 20 pm

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit cfa61fb
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65c5ba64d840010008c64857

@lambry lambry marked this pull request as ready for review February 9, 2024 05:43
Copy link

cypress bot commented Feb 9, 2024

Passing run #1269 ↗︎

0 125 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): add RplPageComponent wrapper
Project: ripple-framework Commit: cfa61fbe5b
Status: Passed Duration: 06:08 💡
Started: Feb 9, 2024 5:41 AM Ended: Feb 9, 2024 5:47 AM

Review all test suite changes for PR #1014 ↗︎

@lambry lambry added this pull request to the merge queue Feb 12, 2024
Merged via the queue into develop with commit 540a6e6 Feb 12, 2024
16 checks passed
@lambry lambry deleted the feature/R20-1742-before-results-content branch February 12, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants