Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1699] remove unused vars and padding from data table #1016

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[R20-1699] remove unused vars and padding from data table #1016

merged 1 commit into from
Jan 30, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 30, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1699

What I did

  • Remove unused vars and padding from data table

The main RplTable background was being set to nothing for data tables, @waitingallday do you happen to remember what these lines were for? https://github.com/dpc-sdp/ripple-framework/pull/382/files#diff-cf57cdb1728ef5fce7d68c7a7403c06915828b7e023defdfa2500efda55bc23dR70

Screenshot 2024-01-30 at 9 29 57 am

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jan 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4359d2f
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65b847831ebc730008039b74

@dylankelly dylankelly added this pull request to the merge queue Jan 30, 2024
Merged via the queue into develop with commit c684936 Jan 30, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/R20-1699-table-reset branch January 30, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly