Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@dpc-sdp/ripple-ui-core): allow props to be passed to the main extraContent component #1024

Merged
merged 1 commit into from
Feb 4, 2024
Merged

feat(@dpc-sdp/ripple-ui-core): allow props to be passed to the main extraContent component #1024

merged 1 commit into from
Feb 4, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 2, 2024

What I did

  • Allow props to be passed to the main extraContent component, this will be especially useful for manage labels via config.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Feb 2, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 2, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 7bcf5fb
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65bc861e9ed1b30008462b01

@cypress Cypress
Copy link

cypress bot commented Feb 2, 2024

Passing run #1227 ↗︎

0 118 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-core): allow props to be passed to the main extraContent...
Project: ripple-framework Commit: 7bcf5fba6c
Status: Passed Duration: 05:46 💡
Started: Feb 2, 2024 6:04 AM Ended: Feb 2, 2024 6:10 AM

Review all test suite changes for PR #1024 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Feb 4, 2024
Merged via the queue into develop with commit 04d43e8 Feb 4, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/allow-props-on-extra-content-component branch February 4, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly