Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@dpc-sdp/ripple-ui-core): minor style updates, add new result lis… #1033

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix(@dpc-sdp/ripple-ui-core): minor style updates, add new result lis… #1033

merged 2 commits into from
Feb 12, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 9, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-462

What I did

  • minor style updates
  • add new result listing story

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Feb 9, 2024
@nuxt-studio Nuxt Studio
Copy link

nuxt-studio bot commented Feb 9, 2024

✅ Live Preview ready!

Name Edit Preview Latest Commit
ripple-framework Edit on Studio ↗︎ View Live Preview da456d3

@netlify Netlify
Copy link

netlify bot commented Feb 9, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 45d6762
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65ca968d8e7e9700084336a4

@cypress Cypress
Copy link

cypress bot commented Feb 9, 2024 •
edited
Loading

Passing run #1272 ↗︎

0 125 0 0 Flakiness 0

Details:

Merge branch 'develop' into bugfix/R20-462-results-feedback
Project: ripple-framework Commit: 45d676226b
Status: Passed Duration: 06:30 💡
Started: Feb 12, 2024 10:10 PM Ended: Feb 12, 2024 10:16 PM

Review all test suite changes for PR #1033 ↗︎

@lambry lambry marked this pull request as ready for review February 12, 2024 22:07
@dylankelly dylankelly added this pull request to the merge queue Feb 12, 2024
Merged via the queue into develop with commit 46b9145 Feb 12, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the bugfix/R20-462-results-feedback branch February 12, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly