Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@dpc-sdp/ripple-ui-core): minor style updates, add new result lis… #1033

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix(@dpc-sdp/ripple-ui-core): minor style updates, add new result lis… #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da456d3
fix(@dpc-sdp/ripple-ui-core): minor style updates, add new result lis…
Feb 9, 2024
45d6762
Merge branch 'develop' into bugfix/R20-462-results-feedback
lambry Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/design-system/5.components/results-listing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ When displaying the results listing, consider a user's needs. Only display what

::DocsExample
---
id: core-navigation-result-listing--result-listing
id: core-navigation-result-listing--default-story
---
::

Expand Down
25 changes: 24 additions & 1 deletion packages/ripple-ui-core/src/components/result-listing/RplResultListing.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,36 @@ export const SingleTemplate = (args) => ({

<Canvas>
<Story
name='Result listing'
name='Default'
play={a11yStoryCheck}
>
{SingleTemplate.bind()}
</Story>
</Canvas>


## Simple

This is an example showing a simple version of the result listing

<Canvas>
<Story
name='Simple'
play={a11yStoryCheck}
args={{
number: 3,
title: 'The page title',
url: 'https://www.vic.gov.au/victorian-government-directory',
content: null,
updated: null,
meta: '<span class="rpl-result-listing__topic">Topic</span><span class="rpl-result-listing__published">10 Aug 2022</span>',
}}
>
{SingleTemplate.bind()}
</Story>
</Canvas>


## With Meta

This is an example showing the result listing with metadata
Expand Down
2 changes: 1 addition & 1 deletion packages/ripple-ui-core/src/components/result-listing/RplResultListingItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '@dpc-sdp/ripple-ui-core/style/breakpoints';

.rpl-result-listing-item {
border-top: 1px solid var(--rpl-clr-neutral-300);
border-top: var(--rpl-border-1) solid var(--rpl-clr-neutral-300);
}
11 changes: 10 additions & 1 deletion packages/ripple-ui-core/src/components/result-listing/RplSearchResult.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@

.rpl-search-result__heading {
cursor: pointer;

&:hover a,
&:active a {
text-decoration: none;
}

&:active a {
color: var(--local-clr-link-active, var(--rpl-clr-dark));
}
}

.rpl-search-result__title {
Expand Down Expand Up @@ -67,7 +76,7 @@
margin-top: var(--rpl-sp-2);

em {
font-weight: bold;
font-weight: var(--rpl-type-weight-bold);
font-style: normal;
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ripple-ui-core/src/components/result-listing/RplSearchResult.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const handleClick = () => {
class="rpl-search-result__body rpl-type-p"
v-html="content"
/>
<p v-if="updated" class="rpl-search-result__body rpl-type-p-small">
<p v-if="updated" class="rpl-search-result__date rpl-type-p-small">
{{ dateLabel ? `${dateLabel}: ` : '' }}{{ updated }}
</p>
</div>
Expand Down
Loading