Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1745] Added title attribute when hovering over map pins #1043

Merged
merged 2 commits into from
Feb 20, 2024
Merged

[R20-1745] Added title attribute when hovering over map pins #1043

merged 2 commits into from
Feb 20, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-1745

Screenshot 2024-02-20 at 1 19 05 pm

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Feb 20, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 20, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 2a43ea9
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65d415a1186ad600086fa991

@cypress Cypress
Copy link

cypress bot commented Feb 20, 2024

Passing run #1309 ↗︎

0 126 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-maps): added title attribute to pins on hover
Project: ripple-framework Commit: d7eb18856c
Status: Passed Duration: 06:32 💡
Started: Feb 20, 2024 2:23 AM Ended: Feb 20, 2024 2:30 AM

Review all test suite changes for PR #1043 ↗︎

@jeffdowdle jeffdowdle marked this pull request as ready for review February 20, 2024 02:57
@jeffdowdle jeffdowdle added this pull request to the merge queue Feb 20, 2024
Merged via the queue into develop with commit 599aca6 Feb 20, 2024
5 checks passed
@jeffdowdle jeffdowdle deleted the feature/R20-1745-pin-titles branch February 20, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @lambry @dylankelly