Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@dpc-sdp/ripple-ui-forms): add variant prop to datePicker #1051

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix(@dpc-sdp/ripple-ui-forms): add variant prop to datePicker #1051

merged 1 commit into from
Feb 26, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 26, 2024

What I did

  • add variant prop to datePicker

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Feb 26, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 979655c
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65dc0bd3b9644d0008e19d80

@cypress Cypress
Copy link

cypress bot commented Feb 26, 2024

Passing run #1337 ↗︎

0 126 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-forms): add variant prop to datePicker
Project: ripple-framework Commit: 979655c78e
Status: Passed Duration: 06:29 💡
Started: Feb 26, 2024 3:53 AM Ended: Feb 26, 2024 3:59 AM

Review all test suite changes for PR #1051 ↗︎

@dylankelly dylankelly enabled auto-merge February 26, 2024 22:50
@dylankelly dylankelly added this pull request to the merge queue Feb 26, 2024
Merged via the queue into develop with commit fa15c19 Feb 26, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the bugfix/datepicker-variant-prop branch February 26, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly