Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1733] Add hook for customizing map zoom behaviour #1053

Merged
merged 2 commits into from
Mar 4, 2024
Merged

[R20-1733] Add hook for customizing map zoom behaviour #1053

merged 2 commits into from
Mar 4, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-1733

Example hook that zooms into the closest pin to a suburb
Screenshot 2024-02-28 at 2 12 12 pm

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Feb 28, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 3f83ca5
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65deb1813dfa010008bb2eff

@cypress Cypress
Copy link

cypress bot commented Feb 28, 2024 •
edited
Loading

Passing run #1345 ↗︎

0 126 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): check for map hook before calling it
Project: ripple-framework Commit: 3f83ca537d
Status: Passed Duration: 06:31 💡
Started: Feb 28, 2024 4:10 AM Ended: Feb 28, 2024 4:16 AM

Review all test suite changes for PR #1053 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Mar 4, 2024
Merged via the queue into develop with commit 85b1255 Mar 4, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/R20-1733-station-finder branch March 4, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffdowdle @lambry @waitingallday @dylankelly