Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add belowFilter component to search config #1057

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

waitingallday
Copy link
Member

@waitingallday waitingallday commented Mar 1, 2024

Issue:

What I did

  • Added belowFilter key into search results config e.g.
  "config": {
    ...
    "layoutConfig": {
      "belowFilter": {
        "component": "SomeAribtraryComponent"
      }
    },
  • The presence of a component in config will set padding below the hero header to 0 to allow flexibility of styling (the component can recreate padding below it if needed)

How to test

  • Cypress

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Mar 1, 2024
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 1229be1
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65e5466e250fe60008f3ae3f

Copy link

cypress bot commented Mar 1, 2024

Passing run #1362 ↗︎

0 132 0 0 Flakiness 0

Details:

Merge branch 'develop' into feat/below-filter-search-component
Project: ripple-framework Commit: 1229be11d7
Status: Passed Duration: 06:14 💡
Started: Mar 4, 2024 3:59 AM Ended: Mar 4, 2024 4:05 AM

Review all test suite changes for PR #1057 ↗︎

@waitingallday waitingallday dismissed dylankelly’s stale review March 4, 2024 03:57

Moved to top-level key "layoutConfig"

@waitingallday waitingallday requested a review from dylankelly March 4, 2024 03:57
@dylankelly dylankelly added this pull request to the merge queue Mar 4, 2024
Merged via the queue into develop with commit 2db06e0 Mar 4, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feat/below-filter-search-component branch March 4, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants