Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: infinite dependent filters #1064

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat: infinite dependent filters #1064

merged 2 commits into from
Mar 12, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 12, 2024

What I did

  • Add support for any number of nested dependent filters
Screenshot 2024-03-12 at 11 06 43 am

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Mar 12, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit d339134
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65efa0ddf7a1a100086c9d3c

dylankelly
dylankelly approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @lambry ! Please merge when ready

@lambry lambry added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit 6bd00e8 Mar 12, 2024
16 checks passed
@lambry lambry deleted the feature/infinite-dependent-filters branch March 12, 2024 00:59
@lambry lambry restored the feature/infinite-dependent-filters branch March 26, 2024 02:57
@lambry lambry deleted the feature/infinite-dependent-filters branch April 9, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly