Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1810] add ability to customise maps tab order #1066

Merged
merged 2 commits into from
Mar 17, 2024
Merged

[R20-1810] add ability to customise maps tab order #1066

merged 2 commits into from
Mar 17, 2024

Conversation

dylankelly
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit a039c87
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65f3e52e6d4b6c0007c8265f

@jeffdowdle jeffdowdle self-requested a review March 13, 2024 22:52
@dylankelly dylankelly force-pushed the feature/R20-1810-custom-tab-order branch from 4fc2ddb to a039c87 Compare March 15, 2024 06:05
@cypress Cypress
Copy link

cypress bot commented Mar 15, 2024

Passing run #1409 ↗︎

0 138 0 0 Flakiness 0

Details:

test(@dpc-sdp/ripple-ui-core): ✅ fix component tests
Project: ripple-framework Commit: a039c873cf
Status: Passed Duration: 06:30 💡
Started: Mar 15, 2024 6:08 AM Ended: Mar 15, 2024 6:14 AM

Review all test suite changes for PR #1066 ↗︎

@dylankelly dylankelly enabled auto-merge March 17, 2024 22:44
@dylankelly dylankelly added this pull request to the merge queue Mar 17, 2024
Merged via the queue into develop with commit 1131019 Mar 17, 2024
16 checks passed
@dylankelly dylankelly deleted the feature/R20-1810-custom-tab-order branch March 17, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dylankelly @lambry @waitingallday @jeffdowdle