Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1828] make popup section props the same #1072

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 18, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1828

What I did

  • I don't believe this has been used yet, so I'm just making the props for the popupTitle and popupContent components the same, i.e. they're both take a feature props now instead of one being feature and the other being selectedFeature

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit c680d6b
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65f79f0d661ecb00083ea0c0

Copy link

cypress bot commented Mar 18, 2024

Passing run #1417 ↗︎

0 138 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-search): make popup section props the same
Project: ripple-framework Commit: c680d6b784
Status: Passed Duration: 06:43 💡
Started: Mar 18, 2024 1:55 AM Ended: Mar 18, 2024 2:02 AM

Review all test suite changes for PR #1072 ↗︎

@lambry lambry added this pull request to the merge queue Mar 18, 2024
Merged via the queue into develop with commit 6cb3729 Mar 18, 2024
8 checks passed
@lambry lambry deleted the feature/R20-1828-popup-title branch March 18, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants