Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1831] add label and placeholder props to address lookup #1076

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[R20-1831] add label and placeholder props to address lookup #1076

merged 1 commit into from
Mar 19, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 19, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1831

What I did

  • add label and placeholder props to address lookup component

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Mar 19, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 388dd64
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65f8d9d523b7cd0009f0d943

@cypress Cypress
Copy link

cypress bot commented Mar 19, 2024

Passing run #1429 ↗︎

0 138 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-search): add label and placeholder props to address lo...
Project: ripple-framework Commit: 388dd64ad7
Status: Passed Duration: 07:05 💡
Started: Mar 19, 2024 12:15 AM Ended: Mar 19, 2024 12:23 AM

Review all test suite changes for PR #1076 ↗︎

@waitingallday waitingallday added this pull request to the merge queue Mar 19, 2024
Merged via the queue into develop with commit 28bfa69 Mar 19, 2024
8 checks passed
@waitingallday waitingallday deleted the feature/R20-1831-customise-label-placeholder branch March 19, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @jeffdowdle