Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1818] explicitly close popups #1081

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[R20-1818] explicitly close popups #1081

merged 1 commit into from
Mar 20, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 20, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1818

What I did

  • Rejig closing map popups to be explicit, this means more events triggering the popups to close but better feedback. i.e. they close straight away.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Mar 20, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 20, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 8d6bb16
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65fb672da7f713000887e76a

@lambry lambry added this pull request to the merge queue Mar 20, 2024
Merged via the queue into develop with commit 867c7bf Mar 20, 2024
8 checks passed
@lambry lambry deleted the bugfix/R20-1818-popups-stay-open branch March 20, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle