Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): 🐛 fix docs issues #1087

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(docs): 🐛 fix docs issues #1087

merged 1 commit into from
Mar 21, 2024

Conversation

waitingallday
Copy link
Member

Issue: Fixes #730

What I did

  • Added separate story for numbered accordion example (wasn't respecting param, I suspect it's a type issue), relinked docs page
  • Removed 'updated date' from docs, since none of our examples or uses have this

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for ripple-docs ready!

Name Link
🔨 Latest commit 93510fc
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65fbb36a8a60da0008c8ae08
😎 Deploy Preview https://deploy-preview-1087--ripple-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dylankelly dylankelly added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit 7e8c5aa Mar 21, 2024
16 checks passed
@dylankelly dylankelly deleted the fix/docs-feedback branch March 21, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect storybook visuals on ripple 2 doc site
4 participants