Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1813] make custom collection expanded config the same as search listings #1089

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[R20-1813] make custom collection expanded config the same as search listings #1089

merged 1 commit into from
Mar 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 21, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1813

What I did

  • make custom collection expanded config the same as search listings
  • remove unused showFiltersOnLoad prop from search listing

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

refactor(@dpc-sdp/ripple-tide-search): make custom collection expande…
a184d19 
…d config the same as listings

remove unused showFiltersOnLoad prop from search listing
@lambry lambry requested review from dylankelly and jeffdowdle March 21, 2024 22:45
@lambry lambry self-assigned this Mar 21, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit a184d19
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65fcb891f529c10008070034

@dylankelly dylankelly enabled auto-merge March 21, 2024 22:52
@dylankelly dylankelly added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit 9d12b84 Mar 21, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/R20-1813-expand-custom-collection-filters branch March 21, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle