From 8bac9bbfb2b81ee1b29b410d551e039207815c2f Mon Sep 17 00:00:00 2001 From: Dana Powers Date: Thu, 8 Mar 2018 13:13:20 -0500 Subject: [PATCH 1/2] Log socket error string with connection errors --- kafka/conn.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kafka/conn.py b/kafka/conn.py index b0d602917..0ba9c47cd 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -343,7 +343,8 @@ def connect(self): elif ret not in (errno.EINPROGRESS, errno.EALREADY, errno.EWOULDBLOCK, 10022): log.error('Connect attempt to %s returned error %s.' ' Disconnecting.', self, ret) - self.close(Errors.ConnectionError(ret)) + errstr = errno.errorcode.get(ret, 'UNKNOWN') + self.close(Errors.ConnectionError('{} {}'.format(ret, errstr))) # Connection timed out elif time.time() > request_timeout + self.last_attempt: From 1e6c3c93fcd812d2cfbec0a478683b6561b207cf Mon Sep 17 00:00:00 2001 From: Dana Powers Date: Wed, 7 Mar 2018 15:38:19 -0800 Subject: [PATCH 2/2] Log connected as INFO --- kafka/conn.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kafka/conn.py b/kafka/conn.py index 0ba9c47cd..54415a2bc 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -333,7 +333,7 @@ def connect(self): self.state = ConnectionStates.AUTHENTICATING else: # security_protocol PLAINTEXT - log.debug('%s: Connection complete.', self) + log.info('%s: Connection complete.', self) self.state = ConnectionStates.CONNECTED self._reset_reconnect_backoff() self.config['state_change_callback'](self) @@ -362,7 +362,7 @@ def connect(self): log.debug('%s: initiating SASL authentication', self) self.state = ConnectionStates.AUTHENTICATING else: - log.debug('%s: Connection complete.', self) + log.info('%s: Connection complete.', self) self.state = ConnectionStates.CONNECTED self.config['state_change_callback'](self) @@ -371,7 +371,7 @@ def connect(self): if self._try_authenticate(): # _try_authenticate has side-effects: possibly disconnected on socket errors if self.state is ConnectionStates.AUTHENTICATING: - log.debug('%s: Connection complete.', self) + log.info('%s: Connection complete.', self) self.state = ConnectionStates.CONNECTED self._reset_reconnect_backoff() self.config['state_change_callback'](self)