From 827fc27e5268ca6c7d8eaafb10bffb0cdbd57a0f Mon Sep 17 00:00:00 2001 From: Jeff Widman Date: Fri, 26 Oct 2018 14:09:54 -0700 Subject: [PATCH 1/2] Add temp workaround for upstream pylint bug Temporarily workaround https://github.com/PyCQA/pylint/issues/2571 so that we can stop pinning `pylint`. --- kafka/record/_crc32c.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kafka/record/_crc32c.py b/kafka/record/_crc32c.py index 9db2d89af..ecff48f5e 100644 --- a/kafka/record/_crc32c.py +++ b/kafka/record/_crc32c.py @@ -139,5 +139,7 @@ def crc(data): if __name__ == "__main__": import sys - data = sys.stdin.read() + # TODO remove the pylint disable once pylint fixes + # https://github.com/PyCQA/pylint/issues/2571 + data = sys.stdin.read() # pylint: disable=assignment-from-no-return print(hex(crc(data))) From 80b34bd4090148a9a46ebc89971959f7a46c32c6 Mon Sep 17 00:00:00 2001 From: Jeff Widman Date: Wed, 24 Oct 2018 22:50:06 -0700 Subject: [PATCH 2/2] Stop pinning `pylint` We have many deprecation warnings in the travis logs for things that are fixed in newer versions of `pylint` or `pylint`'s dependencies. Note that `pylint` >= 2.0 does not support python 2, so this will result in different versions of pylint running for python 2 vs python 3. Personally, I am just fine with this. --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tox.ini b/tox.ini index ad95f9374..1760afffc 100644 --- a/tox.ini +++ b/tox.ini @@ -11,7 +11,7 @@ log_format = %(created)f %(filename)-23s %(threadName)s %(message)s deps = pytest pytest-cov - py{27,34,35,36,py}: pylint==1.8.2 + py{27,34,35,36,py}: pylint py{27,34,35,36,py}: pytest-pylint pytest-mock mock