Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove outdated example doc #1435

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Oct 8, 2023

These docs and configs are poorly maintained, and it also can be replaced by the doc https://github.com/dragonflyoss/image-service/blob/master/docs/containerd-env-setup.md.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

These docs and configs are poorly maintained, and it also can be
replaced by the doc https://github.com/dragonflyoss/image-service/blob/master/docs/containerd-env-setup.md.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@imeoer imeoer requested a review from a team as a code owner October 8, 2023 08:42
@imeoer imeoer requested review from jiangliu, luodw and changweige and removed request for a team October 8, 2023 08:42
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #1435 (18af837) into master (d7b1851) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
- Coverage   46.42%   46.40%   -0.03%     
==========================================
  Files         123      123              
  Lines       38745    38745              
  Branches    38745    38745              
==========================================
- Hits        17986    17978       -8     
- Misses      19789    19794       +5     
- Partials      970      973       +3     

see 3 files with indirect coverage changes

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@imeoer imeoer merged commit 6ea22cc into dragonflyoss:master Oct 9, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants