Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change images-service to nydus #1459

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Oct 31, 2023

Relevant Issue (if applicable)

Since #1405, we had changed repo name to nydus.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Since dragonflyoss#1405, we had changed repo name to nydus.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested review from a team as code owners October 31, 2023 05:21
@Desiki-high Desiki-high requested review from liubin, imeoer and changweige and removed request for a team October 31, 2023 05:21
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1459 (5b5ece2) into master (55bba9d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1459   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files         123      123           
  Lines       38896    38896           
  Branches    38896    38896           
=======================================
+ Hits        17259    17261    +2     
+ Misses      20696    20695    -1     
+ Partials      941      940    -1     

see 3 files with indirect coverage changes

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@imeoer imeoer merged commit e64b912 into dragonflyoss:master Oct 31, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants