Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.2] nydusify: fix copy race issue #1466

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Nov 2, 2023

  1. Fix lost namespace on containerd image pull context:
pull source image: namespace is required: failed precondition
  1. Fix possible semaphore Acquire race on the same one context:
panic: semaphore: released more than held

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

1. Fix lost namespace on containerd image pull context:

```
pull source image: namespace is required: failed precondition
```

2. Fix possible semaphore Acquire race on the same one context:

```
panic: semaphore: released more than held
```

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@imeoer imeoer requested a review from a team as a code owner November 2, 2023 09:11
@imeoer imeoer requested review from liubogithub, luodw and changweige and removed request for a team November 2, 2023 09:11
@bergwolf bergwolf merged commit 1c9c819 into dragonflyoss:stable/v2.2 Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants