-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fs_version and compressor output of nydus image check #1552
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
- Coverage 61.40% 61.34% -0.07%
==========================================
Files 144 144
Lines 46962 47001 +39
Branches 44498 44537 +39
==========================================
- Hits 28837 28832 -5
- Misses 16646 16685 +39
- Partials 1479 1484 +5
|
c4b1f93
to
7282bd2
Compare
5e0fead
to
2ee75df
Compare
2ee75df
to
abcdbfc
Compare
abcdbfc
to
0c53842
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other LGTM, thanks!
0c53842
to
6bac709
Compare
1.Add rafs_version value, output like 5 or 6. 2.Add compressor algorithm value, like ztsd. Add rafs_version and compressor json output of nydus image check,so that more info can be get if it is necessary. Signed-off-by: YuQiang <y_q_email@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you update the nydus-image check
usage in docs/nydus-image.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.