Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fs_version and compressor output of nydus image check #1552

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

PerseidMeteor
Copy link
Contributor

@PerseidMeteor PerseidMeteor commented Feb 26, 2024

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

  1. Add fs_version value, output v5 or v6.
  2. Add compressor algorithm value, like ztsd.
  3. Add rafs_version and compressor JSON output of nydus image check, so that more info can be get if it is necessary.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@PerseidMeteor PerseidMeteor requested a review from a team as a code owner February 26, 2024 13:56
@PerseidMeteor PerseidMeteor requested review from gaius-qi, changweige and adamqqqplay and removed request for a team February 26, 2024 13:56
@PerseidMeteor PerseidMeteor changed the title feat: add rafs_version and compressor output of nydus image check [WIP]feat: add rafs_version and compressor output of nydus image check Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 61.34%. Comparing base (7b3cc50) to head (6bac709).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1552      +/-   ##
==========================================
- Coverage   61.40%   61.34%   -0.07%     
==========================================
  Files         144      144              
  Lines       46962    47001      +39     
  Branches    44498    44537      +39     
==========================================
- Hits        28837    28832       -5     
- Misses      16646    16685      +39     
- Partials     1479     1484       +5     
Files Coverage Δ
rafs/src/metadata/mod.rs 70.45% <0.00%> (-0.54%) ⬇️
src/bin/nydus-image/validator.rs 0.00% <0.00%> (ø)
src/bin/nydus-image/main.rs 0.69% <0.00%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

src/bin/nydus-image/main.rs Outdated Show resolved Hide resolved
src/bin/nydus-image/main.rs Outdated Show resolved Hide resolved
@PerseidMeteor PerseidMeteor changed the title [WIP]feat: add rafs_version and compressor output of nydus image check feat: add rafs_version and compressor output of nydus image check Feb 27, 2024
@PerseidMeteor PerseidMeteor changed the title feat: add rafs_version and compressor output of nydus image check feat: add fs_version and compressor output of nydus image check Feb 27, 2024
@PerseidMeteor PerseidMeteor force-pushed the feat-image-check branch 2 times, most recently from 5e0fead to 2ee75df Compare February 27, 2024 09:04
src/bin/nydus-image/main.rs Outdated Show resolved Hide resolved
src/bin/nydus-image/main.rs Outdated Show resolved Hide resolved
src/bin/nydus-image/main.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM, thanks!

src/bin/nydus-image/main.rs Outdated Show resolved Hide resolved
1.Add rafs_version value, output like 5 or 6.
2.Add compressor algorithm value, like ztsd.
Add rafs_version and compressor json output of nydus image check,so that more info can be get if it is necessary.

Signed-off-by: YuQiang <y_q_email@163.com>
Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update the nydus-image check usage in docs/nydus-image.md ?

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imeoer imeoer merged commit aaab560 into dragonflyoss:master Feb 29, 2024
25 checks passed
@PerseidMeteor
Copy link
Contributor Author

Thanks! Could you update the nydus-image check usage in docs/nydus-image.md ?

docs/nydus-image.md will be updated later.

@PerseidMeteor PerseidMeteor deleted the feat-image-check branch February 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants