Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compression method support to zran docs #1563

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add compression method support to zran docs #1563

merged 1 commit into from
Mar 25, 2024

Conversation

aochagavia
Copy link
Contributor

Relevant Issue (if applicable)

Closes #1562

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@aochagavia aochagavia requested a review from a team as a code owner March 25, 2024 09:30
@aochagavia aochagavia requested review from ccx1024cc, gaius-qi and changweige and removed request for a team March 25, 2024 09:30
imeoer
imeoer approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer
Copy link
Collaborator

imeoer commented Mar 25, 2024

Only need to fix the DCO check. :)

@aochagavia
Add compression method support to zran docs
53de7fd 
Signed-off-by: Adolfo Ochagavía <github@adolfo.ochagavia.nl>
@aochagavia
Copy link
Contributor Author

DCO should be fixed now 👍

@imeoer imeoer merged commit 2308efa into dragonflyoss:master Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@ccx1024cc ccx1024cc Awaiting requested review from ccx1024cc ccx1024cc is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@gaius-qi gaius-qi Awaiting requested review from gaius-qi gaius-qi is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@changweige changweige Awaiting requested review from changweige changweige is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document whether Nydus Zran supports zstd layers
2 participants
@aochagavia @imeoer