-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update containerd-env-setup.md #505
Conversation
@aa624545345 Thanks for the contribution, please add SOB (signed off by) for the commit, thanks! :) |
docs/containerd-env-setup.md
Outdated
@@ -6,6 +6,8 @@ This document will walk through how to setup a nydus image service to work with | |||
|
|||
Get `nydus-image`, `nydusd`, `nydusify`, `ctr-remote` and `nydus-overlayfs` binaries from [image-service release](https://github.com/dragonflyoss/image-service/releases/latest) page. | |||
|
|||
`nydusd` currently has two binaries, `nydusd-fusedev` (for fuse daemon mode) and `nydusd-virtiofs` (for virtiofs daemon mode), chose the one that fits your mode and rename it `nydusd`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a typo here? Should the correct one be "choose"?
And "rename it as nydusd
"would be better?
@aa624545345 , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
@aa624545345 , the test job has been submitted. Please wait in patience. |
@aa624545345 , The CI test is completed, please check result:
Congratulations, your test job passed! |
@aa624545345 , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
@aa624545345 , your test job has passed, and no need to test again. |
We still can't merge this PR since it fails DCO check. |
@aa624545345 , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
@aa624545345 , the test job has been submitted. Please wait in patience. |
Signed-off-by: qiaochen <qiao.chen@zte.com.cn>
@aa624545345 , your pull request has been updated, but a test job is already running. A new test job wil be submitted after the current job is finished. |
@aa624545345 , your test job is running now. Please wait in patience. |
@aa624545345 , The CI test is completed, please check result:
Sorry, the current test job result is not valid, because your pull request has been updated, and a new test job will be submitted. |
Add the description of the two nydusd binaries.