Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containerd-env-setup.md #505

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

aa624545345
Copy link
Contributor

Add the description of the two nydusd binaries.

@imeoer
Copy link
Collaborator

imeoer commented Jun 17, 2022

@aa624545345 Thanks for the contribution, please add SOB (signed off by) for the commit, thanks! :)

@@ -6,6 +6,8 @@ This document will walk through how to setup a nydus image service to work with

Get `nydus-image`, `nydusd`, `nydusify`, `ctr-remote` and `nydus-overlayfs` binaries from [image-service release](https://github.com/dragonflyoss/image-service/releases/latest) page.

`nydusd` currently has two binaries, `nydusd-fusedev` (for fuse daemon mode) and `nydusd-virtiofs` (for virtiofs daemon mode), chose the one that fits your mode and rename it `nydusd`.
Copy link
Contributor

@changweige changweige Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a typo here? Should the correct one be "choose"?
And "rename it as nydusd "would be better?

@yqleng1987
Copy link
Contributor

@aa624545345 , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@aa624545345 , the test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@aa624545345 , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Congratulations, your test job passed!

@yqleng1987
Copy link
Contributor

@aa624545345 , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@aa624545345 , your test job has passed, and no need to test again.

@changweige
Copy link
Contributor

We still can't merge this PR since it fails DCO check.
Please try to refer to https://github.com/dragonflyoss/image-service/pull/505/checks?check_run_id=6986289482 for further information and then tweak your patch commit message.

@yqleng1987
Copy link
Contributor

@aa624545345 , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@aa624545345 , the test job has been submitted. Please wait in patience.

Signed-off-by: qiaochen <qiao.chen@zte.com.cn>
@yqleng1987
Copy link
Contributor

@aa624545345 , your pull request has been updated, but a test job is already running. A new test job wil be submitted after the current job is finished.

@yqleng1987
Copy link
Contributor

@aa624545345 , your test job is running now. Please wait in patience.

@yqleng1987
Copy link
Contributor

@aa624545345 , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Sorry, the current test job result is not valid, because your pull request has been updated, and a new test job will be submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants