Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: update version on build automatically #735

Merged
merged 1 commit into from
Oct 13, 2022
Merged

release: update version on build automatically #735

merged 1 commit into from
Oct 13, 2022

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Sep 20, 2022

We only need to git tag to release a version without modifying
the version field in Cargo.toml and Cargo.lock.

Signed-off-by: Yan Song imeoer@linux.alibaba.com

@anolis-bot
Copy link
Collaborator

@imeoer , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21912

@imeoer imeoer changed the title release: update version in Cargo.toml automatically [WIP] release: update version in Cargo.toml automatically Sep 20, 2022
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@changweige
Copy link
Contributor

Looks cool 👍 . But better the logic replacing versions in Cargo.toml is performed from Makefile since some vendors are compiling nydus artifacts by themselves.

@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer changed the title [WIP] release: update version in Cargo.toml automatically release: update version in Cargo.toml automatically Oct 13, 2022
@anolis-bot
Copy link
Collaborator

@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26438

@imeoer imeoer changed the title release: update version in Cargo.toml automatically release: update version on build automatically Oct 13, 2022
@anolis-bot
Copy link
Collaborator

@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26439

@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26447

changweige
changweige reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also help apply this method to nydusctl ?

gechangwei@n227-089-202 ~/git_repo/nydus-rs (release-version)$ ./target/debug/nydusctl --version
A client to query and configure the nydusd daemon
 0.0.0-git

@imeoer
release: update version on build automatically
9058227 
We only need to git tag to release a version without modifying
the version field in Cargo.toml and Cargo.lock.

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26458

changweige
changweige approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changweige changweige merged commit 996f75a into dragonflyoss:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changweige changweige changweige approved these changes

Assignees
No one assigned
Labels
anolis_test_pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imeoer @anolis-bot @changweige