builder: fix redundant blob for inline bootstrap #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
force-pushed
the
builder-fix-redundant-blob
branch
from
f17c401
to
6b61e7c
Compare
The previous code generates a new empty blob for inline bootstrap mode:
```
if ctx.inline_bootstrap {
let (_, _) = blob_mgr.get_or_create_current_blob(ctx)?;
}
```
And then the empty blob will be appended to blob table although
no chunk data be generated in the current build.
This patch avoids generating this kind of redundant blob.
Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
anolis-bot
added
anolis_test_fail
anolis_testing
anolis_test_pass
and removed
anolis_testing
anolis_test_fail
labels
imeoer
force-pushed
the
builder-fix-redundant-blob
branch
from
6b61e7c
to
bae6276
Compare
anolis-bot
added
anolis_testing
anolis_test_pass
and removed
anolis_test_pass
anolis_testing
labels
jiangliu
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code generates a new empty blob for inline bootstrap mode:
And then the empty blob will be appended to blob table although
no chunk data be generated in the current build.
This patch avoids generating this kind of redundant blob.
Signed-off-by: Yan Song imeoer@linux.alibaba.com