From d74d54915a8417bc1d5630c0f6d99b70472b56ab Mon Sep 17 00:00:00 2001
From: gggpound <gpoundLiu@gmail.com>
Date: Sat, 23 Mar 2024 16:19:37 +0800
Subject: [PATCH] fix(cf): compose bius config (#487)

---
 .../conditional-style-editor/index.tsx        | 53 ++++++++++++-------
 .../src/utils/removeUndefinedAttr.ts          | 34 ++++++++++++
 2 files changed, 68 insertions(+), 19 deletions(-)
 create mode 100644 packages/sheets-conditional-format/src/utils/removeUndefinedAttr.ts

diff --git a/packages/sheets-conditional-format/src/components/conditional-style-editor/index.tsx b/packages/sheets-conditional-format/src/components/conditional-style-editor/index.tsx
index 79040f89d8e2..8ee234820070 100644
--- a/packages/sheets-conditional-format/src/components/conditional-style-editor/index.tsx
+++ b/packages/sheets-conditional-format/src/components/conditional-style-editor/index.tsx
@@ -21,7 +21,7 @@ import { useDependency } from '@wendellhu/redi/react-bindings';
 import cl from 'clsx';
 import { ColorPicker } from '../color-picker';
 import type { IHighlightCell } from '../../models/type';
-import { DEFAULT_BG_COLOR, DEFAULT_FONT_COLOR } from '../../base/const';
+import { removeUndefinedAttr } from '../../utils/removeUndefinedAttr';
 import styles from './index.module.less';
 
 interface IConditionalStyleEditorProps {
@@ -30,36 +30,36 @@ interface IConditionalStyleEditorProps {
     onChange: (style: IHighlightCell['style']) => void;
 };
 
-const getAnotherBooleanNumber = (v: BooleanNumber) => {
-    return v === BooleanNumber.FALSE ? BooleanNumber.TRUE : BooleanNumber.FALSE;
+const getAnotherBooleanNumber = (v: BooleanNumber | undefined) => {
+    return [BooleanNumber.FALSE, undefined].includes(v) ? BooleanNumber.TRUE : BooleanNumber.FALSE;
 };
 const getBooleanFromNumber = (v: BooleanNumber) => v !== BooleanNumber.FALSE;
 export const ConditionalStyleEditor = (props: IConditionalStyleEditorProps) => {
     const { style, onChange, className } = props;
     const componentManager = useDependency(ComponentManager);
-    const [isBold, isBoldSet] = useState(() => {
-        const defaultV = BooleanNumber.FALSE;
+    const [isBold, isBoldSet] = useState<BooleanNumber | undefined>(() => {
+        const defaultV = undefined;
         if (!style?.bl) {
             return defaultV;
         }
         return style.bl;
     });
-    const [isItalic, isItalicSet] = useState(() => {
-        const defaultV = BooleanNumber.FALSE;
+    const [isItalic, isItalicSet] = useState<BooleanNumber | undefined>(() => {
+        const defaultV = undefined;
         if (!style?.it) {
             return defaultV;
         }
         return style.it;
     });
-    const [isUnderline, isUnderlineSet] = useState(() => {
-        const defaultV = BooleanNumber.FALSE;
+    const [isUnderline, isUnderlineSet] = useState<BooleanNumber | undefined>(() => {
+        const defaultV = undefined;
         if (!style?.ul) {
             return defaultV;
         }
         return style.ul.s;
     });
-    const [isStrikethrough, isStrikethroughSet] = useState(() => {
-        const defaultV = BooleanNumber.FALSE;
+    const [isStrikethrough, isStrikethroughSet] = useState<BooleanNumber | undefined>(() => {
+        const defaultV = undefined;
         if (!style?.st) {
             return defaultV;
         }
@@ -84,34 +84,49 @@ export const ConditionalStyleEditor = (props: IConditionalStyleEditorProps) => {
     const UnderlineSingleIcon = componentManager.get('UnderlineSingle');
     const StrikethroughSingle = componentManager.get('StrikethroughSingle');
     useEffect(() => {
-        const resultStyle: IHighlightCell['style'] = { cl: { rgb: fontColor }, bg: { rgb: bgColor }, bl: isBold, it: isItalic, st: { s: isStrikethrough }, ul: { s: isUnderline } };
-        onChange(resultStyle);
+        const resultStyle: IHighlightCell['style'] = {
+            bl: isBold,
+            it: isItalic,
+        };
+        if (fontColor !== undefined) {
+            resultStyle.cl = { rgb: fontColor };
+        }
+        if (bgColor !== undefined) {
+            resultStyle.bg = { rgb: bgColor };
+        }
+        if (isStrikethrough !== undefined) {
+            resultStyle.st = { s: isStrikethrough };
+        }
+        if (isUnderline !== undefined) {
+            resultStyle.ul = { s: isUnderline };
+        }
+        onChange(removeUndefinedAttr(resultStyle));
     // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [isBold, isItalic, isUnderline, isStrikethrough, fontColor, bgColor]);
     return (
         <div className={`${styles.cfStyleEdit} ${className}`}>
             { BoldSingleIcon && (
-                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isBold) }, styles.buttonItem)} onClick={() => isBoldSet(getAnotherBooleanNumber(isBold))}>
+                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isBold || BooleanNumber.FALSE) }, styles.buttonItem)} onClick={() => isBoldSet(getAnotherBooleanNumber(isBold))}>
                     <BoldSingleIcon />
                 </div>
             )}
             { ItalicSingleIcon && (
-                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isItalic) }, styles.buttonItem)} onClick={() => isItalicSet(getAnotherBooleanNumber(isItalic))}>
+                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isItalic || BooleanNumber.FALSE) }, styles.buttonItem)} onClick={() => isItalicSet(getAnotherBooleanNumber(isItalic))}>
                     <ItalicSingleIcon />
                 </div>
             )}
             { UnderlineSingleIcon && (
-                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isUnderline) }, styles.buttonItem)} onClick={() => isUnderlineSet(getAnotherBooleanNumber(isUnderline))}>
+                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isUnderline || BooleanNumber.FALSE) }, styles.buttonItem)} onClick={() => isUnderlineSet(getAnotherBooleanNumber(isUnderline))}>
                     <UnderlineSingleIcon />
                 </div>
             )}
             { StrikethroughSingle && (
-                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isStrikethrough) }, styles.buttonItem)} onClick={() => isStrikethroughSet(getAnotherBooleanNumber(isStrikethrough))}>
+                <div className={cl({ [styles.isActive]: getBooleanFromNumber(isStrikethrough || BooleanNumber.FALSE) }, styles.buttonItem)} onClick={() => isStrikethroughSet(getAnotherBooleanNumber(isStrikethrough))}>
                     <StrikethroughSingle />
                 </div>
             )}
-            <ColorPicker color={fontColor || DEFAULT_FONT_COLOR} onChange={fontColorSet} iconId="FontColor" />
-            <ColorPicker color={bgColor || DEFAULT_BG_COLOR} onChange={bgColorSet} iconId="PaintBucket" />
+            <ColorPicker color={fontColor} onChange={fontColorSet} iconId="FontColor" />
+            <ColorPicker color={bgColor} onChange={bgColorSet} iconId="PaintBucket" />
         </div>
     );
 };
diff --git a/packages/sheets-conditional-format/src/utils/removeUndefinedAttr.ts b/packages/sheets-conditional-format/src/utils/removeUndefinedAttr.ts
new file mode 100644
index 000000000000..f54b90a397fc
--- /dev/null
+++ b/packages/sheets-conditional-format/src/utils/removeUndefinedAttr.ts
@@ -0,0 +1,34 @@
+/**
+ * Copyright 2023-present DreamNum Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export function removeUndefinedAttr<T = unknown>(obj: T): T {
+    if (typeof obj !== 'object' || obj === null) {
+        return obj;
+    }
+
+    const result: Record<string, any> = {};
+
+    for (const key in obj) {
+        if (obj.hasOwnProperty(key)) {
+            const value = removeUndefinedAttr(obj[key]);
+            if (value !== undefined) {
+                result[key] = value;
+            }
+        }
+    }
+
+    return result as T;
+}