Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(numfmt): support edit percent with numfmt #3190

Merged
merged 3 commits into from
Aug 27, 2024
Merged

fix(numfmt): support edit percent with numfmt #3190

merged 3 commits into from
Aug 27, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Aug 26, 2024 •
edited
Loading

close #3043

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 26, 2024
@Gggpound
Copy link
Contributor Author

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (260f1b6) to head (9e755b4).
Report is 2 commits behind head on dev.

Files Patch % Lines
...numfmt/src/controllers/numfmt.editor.controller.ts 66.66% 2 Missing ⚠️
packages/engine-formula/src/basics/date.ts 66.66% 1 Missing ⚠️
...gine-formula/src/functions/date/datevalue/index.ts 80.00% 1 Missing ⚠️
...gine-formula/src/functions/date/timevalue/index.ts 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #3190      +/-   ##
==========================================
- Coverage   28.64%   28.63%   -0.01%     
==========================================
  Files        2023     2024       +1     
  Lines      106937   106943       +6     
  Branches    23111    23114       +3     
==========================================
- Hits        30628    30625       -3     
- Misses      76309    76318       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 26, 2024
@Gggpound Gggpound requested a review from wzhudev as a code owner August 26, 2024 10:05
@Gggpound Gggpound requested a review from DR-Univer as a code owner August 27, 2024 03:07
@Gggpound Gggpound merged commit d8ca9f6 into dev Aug 27, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-numfmt-0826 branch August 27, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jocs Jocs Jocs approved these changes

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Multiplication with percentages has errors
3 participants
@Gggpound @Jocs @zhaolixin7