fix some issues with converted /manage/profile page (#3441)

* fix bday month

* fix undefined value warnings

Use of uninitialized value in numeric ge (>=) ... cgi-bin/DW/Controller/Manage/Profile.pm line 258.

Use of uninitialized value $newbio in pattern match (m//) ... cgi-bin/DW/Controller/Manage/Profile.pm line 285.

Use of uninitialized value in numeric gt (>) ... cgi-bin/DW/Controller/Manage/Profile.pm line 348.

* pass $iscomm variable to page template

This was missing from the $vars hash.

* more undefined value warnings

Use of uninitialized value in pattern match (m//) ... cgi-bin/DW/Controller/Manage/Profile.pm line 155.

Use of uninitialized value in pattern match (m//) ... cgi-bin/DW/Controller/Manage/Profile.pm line 172.

* start birthday month menu with empty value

Author: kareila

cgi-bin/DW/Controller/Manage/Profile.pm

@@ -151,8 +151,11 @@ sub profile_handler {
         if ( $bdpart{'day'} eq "00" )    { $bdpart{'day'}  = ""; }
     }
 
-    my @months = map { $_, LJ::Lang::month_long_ml($_) } ( 1 .. 12 );
-    $u->{'opt_showbday'} = "D" unless $u->{'opt_showbday'} =~ m/^(D|F|N|Y)$/;
+    my @months = ( 0, "" );
+    push @months, map { $_, LJ::Lang::month_long_ml($_) } ( 1 .. 12 );
+
+    $u->{'opt_showbday'} = "D"
+        unless defined $u->{'opt_showbday'} and $u->{'opt_showbday'} =~ m/^(D|F|N|Y)$/;
     my $opt_sharebday = ( $u->opt_sharebday =~ m/^(A|F|N|R)$/ ) ? $u->opt_sharebday : 'F';
 
     # 'Other Services' display
@@ -169,7 +172,7 @@ sub profile_handler {
     # Email display
     # This is one prop in the backend, but two form fields on the settings page
     # so we need to do some jumping around to get the correct values for both fields
-    my $checked = ( $u->{'opt_whatemailshow'} =~ /[BVL]/ ) ? 'Y' : 'N';
+    my $checked = ( ( $u->{'opt_whatemailshow'} // '' ) =~ /[BVL]/ ) ? 'Y' : 'N';
     my $cur     = $u->opt_whatemailshow;
 
     # drop BVL values that govern site alias; we input that below instead
@@ -179,6 +182,7 @@ sub profile_handler {
         u                => $u,
         authas_html      => $rv->{authas_html},
         formdata         => $POST,
+        iscomm           => $iscomm,
         curr_privacy     => $curr_privacy,
         opt_sharebday    => $opt_sharebday,
         text_in          => \&LJ::text_in,
@@ -255,7 +259,7 @@ sub profile_handler {
         }
 
         # bio
-        if ( length( $POST->{'bio'} ) >= LJ::BMAX_BIO ) {
+        if ( defined $POST->{'bio'} and length( $POST->{'bio'} ) >= LJ::BMAX_BIO ) {
             $errors->add( 'bio', "$scope.error.bio.toolong" );
         }
 
@@ -282,7 +286,8 @@ sub profile_handler {
         $newname = LJ::text_trim( $newname, LJ::BMAX_NAME, LJ::CMAX_NAME );
 
         my $newbio = defined( $POST->{'bio_absent'} ) ? $saved{'bio'} : $POST->{'bio'};
-        my $has_bio = ( $newbio =~ /\S/ ) ? "Y" : "N";
+        $newbio = "" unless defined $newbio;
+        my $has_bio   = ( $newbio =~ /\S/ ) ? "Y" : "N";
         my $new_bdate = sprintf( "%04d-%02d-%02d",
             $POST->{'year'}  || 0,
             $POST->{'month'} || 0,
@@ -344,7 +349,11 @@ sub profile_handler {
             if ( $POST->{'opt_sharebday'} =~ /^[AR]$/ ) {
 
                 # and actually provided a birthday
-                if ( $POST->{'month'} && $POST->{'month'} > 0 && $POST->{'day'} > 0 ) {
+                if (   $POST->{'month'}
+                    && $POST->{'month'} > 0
+                    && $POST->{'day'}
+                    && $POST->{'day'} > 0 )
+                {
 
                     # and allow the entire thing to be displayed
                     if ( $POST->{'opt_showbday'} eq "F" && $POST->{'year'} ) {

views/manage/profile.tt

@@ -98,7 +98,7 @@
             <td class='field_name' role="cell">[% dw.ml('.fn.birthday') %]</td>
             <td class='bday_field' role="cell">
                 [%- form.select( name => 'month', title => dw.ml('.fn.birthday.month'),
-                                 selected => int( bdpart.month ),
+                                 selected => ( bdpart.month + 0 ),
                                 items => month_select,
                                 class => 'inline'
                                  ) -%]