Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Entries page shows raw HTML #2560

Open
wohali opened this issue Jul 22, 2019 · 0 comments · May be fixed by #2754
Open

Manage Entries page shows raw HTML #2560

wohali opened this issue Jul 22, 2019 · 0 comments · May be fixed by #2754
Assignees
@kareila
Labels
effort: (2) average status: claimed type: parser/markdown/formatting

Comments

@wohali
Copy link
Contributor

wohali commented Jul 22, 2019

Discovered this while working on the new RTE, which writes slightly more advanced (and supported) HTML into posts than the old RTE does:

MWSnap 2019-07-22, 00_13_04

We fully escape all of the content here via LJ::ehtml():

https://github.com/dreamwidth/dw-free/blob/master/htdocs/editjournal.bml#L105-L107

Maybe we should instead strip all tags and just show any textual content, unless that's an empty string, in which case, show the escaped HTML instead.

This is lowish priority, but something should be done before RTE 2.0 comes out of beta...suggestions welcome.
kareila added a commit to kareila/dreamwidth that referenced this issue Jul 12, 2020
@kareila
[dreamwidth#2560] run entry excerpts through HTML cleaner instead of …
e7dd2fe 
…escaping everything

I took a wild stab at this - the options for the cleaner may need to be tweaked further, but this seems like a reasonable first attempt.
@kareila kareila linked a pull request Jul 12, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kareila kareila

Labels
effort: (2) average status: claimed type: parser/markdown/formatting
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2560] run entry excerpts through HTML cleaner instead of escaping everything kareila/dreamwidth
4 participants
@wohali @kareila @momijizukamori @robodw-issues