Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2560] run entry excerpts through HTML cleaner instead of escaping everything #2754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kareila
Copy link
Member

@kareila kareila commented Jul 12, 2020

I took a wild stab at this - the options for the cleaner may need to be tweaked further, but this seems like a reasonable first attempt.

Fixes #2560.

…escaping everything

I took a wild stab at this - the options for the cleaner may need to be tweaked further, but this seems like a reasonable first attempt.
@nfagerlund
Copy link
Contributor

nfagerlund commented Jul 12, 2020

The way all these old BML pages call all these low-level functions constantly makes my skin crawl. 😖

So, LJ::Entry objects already have an event_html_summary method -- would it make more sense to just grab some item IDs ($u->recent_items? at least that's what S2 does), make entry objects, and call that?

The only problem I could think of would be performance concerns, but it seems like that shouldn't be any nastier than just building a last-N journal page, yeah? I checked to see how outrageous this list gets, and while the form will let you request up to 99, it seems to ignore that and actually cap it at 50.

@kareila
Copy link
Member Author

kareila commented Jul 13, 2020

I'm happy to investigate that alternative - I'll flag this as having requested changes until I have time to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Manage Entries page shows raw HTML
4 participants