[WIP] Plack testing #2901
Open
[WIP] Plack testing #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the minimal changes necessary to enable supporting Plack as a runtime environment instead of Apache. The idea is to make running the code much, much simpler since we can have a pure Perl web server and never need to deal with system modules and the increasingly difficult to deal with Apache/mod_perl stuff. However, Plack is a pluggable runtime so it still does support mod_perl so we can do that for efficiency in production if we want. Or, we can start to look at something like Starman.
zorkian
commented
Sep 9, 2021
| # to startup time) | ||
| BEGIN { | ||
| # Do not run if we're in a test | ||
| unless ($LJ::_T_CONFIG) { |
There was a problem hiding this comment.
These moved here because this is basically what mod_perl.pl was doing on startup and I needed to replicate it so that Plack would benefit from the preloading before startup/forking.
zorkian
commented
Sep 9, 2021
| @@ -74,9 +74,6 @@ BEGIN | |||
|
|
|||
| use MIME::Words; | |||
|
|
|||
| # Try to load DBI::Profile | |||
| BEGIN { $LJ::HAVE_DBI_PROFILE = eval "use DBI::Profile (); 1;" } | |||
There was a problem hiding this comment.
This module is never used anywhere.
zorkian
commented
Sep 9, 2021
| # of systems ourselves. | ||
| my $uri = $r->path; | ||
| $log->debug('Routing for URI: ', $uri); | ||
| if ( $uri =~ qr!^/api/v\d+/! ) { |
There was a problem hiding this comment.
This only dispatches to API routes now, but this is where we need to add the rest of the dispatch engines... TT, BML, etc.
Although BML is probably a nightmare to pull off of Apache and maybe we should never support it here, which means Plack can't really be deployed until we finish the BML migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. Just posting for early visibility.
This makes the minimal changes necessary to enable supporting Plack as a
runtime environment instead of Apache.
The idea is to make running the code much, much simpler since we can
have a pure Perl web server and never need to deal with system modules
and the increasingly difficult to deal with Apache/mod_perl stuff.
However, Plack is a pluggable runtime so it still does support mod_perl
so we can do that for efficiency in production if we want. Or, we can
start to look at something like Starman.
CODE TOUR: Major, massive, sweeping backend changes just designed to make it easier to develop on Dreamwidth code, which, y'know, hopefully makes people want to work on it more. Because that'd be cool!