Fix to order by jitemid, not journalid #3018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query was meant to use jitemid (judging from the commit message from 12 years ago), but looks like a typo. Fix it.
zorkian
force-pushed
the
mark/issue-2883
branch
from
784fd0f to
aa3dab0
Compare
|
On further thinking, I think this is wrong, please don't merge. I want to write some test for this behavior. |
|
We made a change to the page boundaries logic in open beta that wound up producing really weird and irregular results with some entries getting eaten entirely, so we backed it out again, which I mention only in case it was relevant because my memory coughed up the overview but not the exact details of the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE TOUR: This query was meant to use jitemid (judging from the commit message from 12 years ago which says
jitemid), but looks like a typo. Fix it. This should address situations where entries with the same timestamp get ordered weirdly, leading to some odd behaviors on page boundaries. Fixes #2883.