Create styling for dead services that indicate that they're no longer available #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et no_link to 1 when printing a dead service
kareila
requested changes
Jun 24, 2023
kareila
requested changes
Jul 9, 2023
| @@ -69,13 +70,17 @@ sub ljuser_display { | |||
| my $display_class = $opts{no_ljuser_class} ? "" : " class='ljuser'"; | |||
| my $domain = $self->site->{domain} ? $self->site->{domain} : $self->site->{hostname}; | |||
|
|
|||
| $nolink = 1 if exists $DW::External::Site::deadsites{$domain}; | |||
There was a problem hiding this comment.
I would suggest combining this line and the initial nolink declaration as follows:
my $nolink = exists $DW::External::Site::deadsites{$domain} ? 1 : 0;
This is called the ternary operator 😄
There was a problem hiding this comment.
Since we're now using a get_deadsites function, this syntax needs to be updated:
my %deadsites = DW::External::Site::get_deadsites();
my $nolink = exists $deadsites{$domain} ? 1 : 0;
Sorry for not noticing that in my previous review! I think that's the last update necessary for this to work.
I would also highly encourage you to make sure your Perl edits are tidy going forward. @momijizukamori posted a pre-commit hook in dw-dev recently to help make this easier!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE TOUR: I went on an arduous journey and learned a lot about arrays in Perl to tweak username display so that dead services aren't linked out and display a default userhead.
Closes #3056.