Draft: Entries api #3305
Open
Draft: Entries api #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2023 00:56
zorkian
reviewed
Nov 24, 2023
| my @entry_tags = $self->tags(); | ||
| $entry->{tags} = ( \@entry_tags ); | ||
| $entry->{icon} = $self->userpic_kw || ''; | ||
| $entry->{entry_id} = delete $self->{ditemid}; |
There was a problem hiding this comment.
why is this deleting the ditemid from $self?
zorkian
reviewed
Nov 24, 2023
| # Authors: | ||
| # Allen Petersen <allen@suberic.net> | ||
| # | ||
| # Copyright (c) 2016 by Dreamwidth Studios, LLC. |
There was a problem hiding this comment.
is this actually a 2016 file by Allen?
There was a problem hiding this comment.
Hilariously for once it actually is - he wrote the base code for the entry fetch and JSON transform of entry objects.
|
Do you want me to do anything on this one right now? |
|
Hmmm I see you left a comment I haven't dealt with, I will look at that. I think I wanted a look-over on the API endpoints for reasonableness, and then more importantly - if we implement this I think we need to be sure we have some sort of rate limit functionality in place in the stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE TOUR: summarize here.