Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

179 upgrade to support dbt core v150 #186

Merged
merged 19 commits into from
Jun 21, 2023
Merged

179 upgrade to support dbt core v150 #186

merged 19 commits into from
Jun 21, 2023

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Jun 18, 2023

Summary

Upgrade dbt-dremio to support dbt-core 1.5.0.

Description

  • Add support Python 3.11
  • Add support for relevant tests
    • caching
    • hooks
    • simple_copy
  • Add support model contracts
  • Upgrades request to 2.31.0 (Closes Upgrade Requests to 2.31.0 #183)

Test Results

  • ./.github/scripts/smoke_test.sh - all pass
  • ./tests/*.* - all pass

Changelog

  • Added a summary of what this PR accomplishes to CHANGELOG.md

Related Issue

#179

@ArgusLi ArgusLi self-assigned this Jun 18, 2023
@ArgusLi ArgusLi linked an issue Jun 18, 2023 that may be closed by this pull request
upgrade to support dbt-core v1.5.0 #179
Closed
4 tasks
ravjotbrar
ravjotbrar suggested changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@ravjotbrar ravjotbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Two main things to change is the naming convention for tests (append Dremio to end of name) and small comment for why we're overriding the fixtures that we are. Maybe not all fixtures need to be overridden in some cases.

rxm7706
rxm7706 reviewed Jun 19, 2023
View reviewed changes
@ArgusLi ArgusLi requested a review from ravjotbrar June 20, 2023 18:46
@ArgusLi ArgusLi merged commit dc58970 into main Jun 21, 2023
@ArgusLi ArgusLi deleted the 179-upgrade-to-support-dbt-core-v150 branch June 21, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxm7706 rxm7706 rxm7706 left review comments

@ravjotbrar ravjotbrar ravjotbrar approved these changes

@arseny-dremio arseny-dremio Awaiting requested review from arseny-dremio

Assignees

@ArgusLi ArgusLi

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Requests to 2.31.0 upgrade to support dbt-core v1.5.0
3 participants
@ArgusLi @ravjotbrar @rxm7706