Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit extension method responseOrNotFound duplicates akka-http built-in directives #75

Open
stewSquared opened this issue Oct 18, 2017 · 3 comments

Comments

@stewSquared
Copy link
Contributor

stewSquared commented Oct 18, 2017

@stewSquared
Copy link
Contributor Author

So, our rejection handler needs to handleNotFound if we want this to 404 by default.
We should fix this pretty soon, since a few services have started using rejectEmptyResponse, and said rejection ends up manifesting as a CORS issue.

cc @zachdriver @vuspenskiy @jodersky

@stewSquared
Copy link
Contributor Author

For future reference, we should add customization like this in terms of akka-http directives rather than as extension methods on OptionT

@zachdriver
Copy link
Contributor

I believe it actually is responding with a 404 when using rejectEmptyResponse. The problem is that it's not adding the CORS headers we need, because we're not handling that rejection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants