From cf2aa6768e1ef786985cfe54ca4a8b83fc1f0270 Mon Sep 17 00:00:00 2001 From: arjunyel Date: Wed, 26 Apr 2023 12:51:47 -0500 Subject: [PATCH] Fix joins docs typo --- .github/ISSUE_TEMPLATE/feature-template.yaml | 4 ++-- CONTRIBUTING.md | 2 +- drizzle-orm/src/mysql-core/README.md | 2 +- drizzle-orm/src/pg-core/README.md | 2 +- drizzle-orm/src/sqlite-core/README.md | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature-template.yaml b/.github/ISSUE_TEMPLATE/feature-template.yaml index 54c5b4d2d..163b179a9 100644 --- a/.github/ISSUE_TEMPLATE/feature-template.yaml +++ b/.github/ISSUE_TEMPLATE/feature-template.yaml @@ -6,7 +6,7 @@ labels: ["enhancement"] body: - type: textarea attributes: - label: Describe want to want - description: What the problrem is? What to want to change or add? + label: Describe what you want + description: What is the problem? What do you want to change or add? validations: required: true diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 08a86858c..928b30151 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -176,7 +176,7 @@ Example [Pg] Add PostGIS extension support ``` -2. PR should contain detailed description with everyting, that was changed +2. PR should contain detailed description with everything, that was changed 3. Each PR should contain - Tests on feature, that was created; diff --git a/drizzle-orm/src/mysql-core/README.md b/drizzle-orm/src/mysql-core/README.md index f57be1a95..c0c6495e0 100644 --- a/drizzle-orm/src/mysql-core/README.md +++ b/drizzle-orm/src/mysql-core/README.md @@ -647,7 +647,7 @@ const users = mysqlTable('users', { cityId: int('city_id').references(() => cities.id), }); -const result = db.select().from(cities).leftJoin(users, eq(cities2.id, users2.cityId)); +const result = db.select().from(cities).leftJoin(users, eq(cities.id, users.cityId)); ``` #### Many-to-many diff --git a/drizzle-orm/src/pg-core/README.md b/drizzle-orm/src/pg-core/README.md index a8ebd06bf..985029632 100644 --- a/drizzle-orm/src/pg-core/README.md +++ b/drizzle-orm/src/pg-core/README.md @@ -658,7 +658,7 @@ const users = pgTable('users', { cityId: integer('city_id').references(() => cities.id), }); -const result = db.select().from(cities).leftJoin(users, eq(cities2.id, users2.cityId)); +const result = db.select().from(cities).leftJoin(users, eq(cities.id, users.cityId)); ``` #### Many-to-many diff --git a/drizzle-orm/src/sqlite-core/README.md b/drizzle-orm/src/sqlite-core/README.md index a73fb6408..dc57eb50f 100644 --- a/drizzle-orm/src/sqlite-core/README.md +++ b/drizzle-orm/src/sqlite-core/README.md @@ -254,7 +254,7 @@ export const countries = sqliteTable('countries', { id: integer('id').primaryKey(), name: text('name'), population: integer('population'), - capital: integer('capital').references(() => cities.id, { onUpdate: 'cascade', onDelete: 'cascade' }) + capital: integer('capital').references(() => cities.id, { onUpdate: 'cascade', onDelete: 'cascade' }) }, (countries) => ({ nameIdx: index('name_idx').on(countries.name), // one column namePopulationIdx: index('name_population_idx').on(countries.name, countries.population), // multiple columns @@ -617,7 +617,7 @@ const users = sqliteTable('users', { const db = drizzle(sqlite); -const result = db.select().from(cities).leftJoin(users, eq(cities2.id, users2.cityId)).all(); +const result = db.select().from(cities).leftJoin(users, eq(cities.id, users.cityId)).all(); ``` ### Many-to-many