[SwiftyDropbox] Update DropboxTransportClient with downloadContentHost #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jamesyangf
changed the title
julianlocke
approved these changes
May 16, 2024
aaronsky
reviewed
May 17, 2024
Source/SwiftyDropbox/Shared/Handwritten/DropboxTransportClient.swift
Outdated
Show resolved
Hide resolved
Source/SwiftyDropbox/Shared/Handwritten/DropboxTransportClient.swift
Outdated
Show resolved
Hide resolved
aaronsky
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download Content Host changes for SwiftyDropbox
Content host for download style request will be different than for upload style.
In order to reflect that, we added the downloadContentHost variable just for download style request.
Caller of this class will be able to pass in the host of their choice for download content host and the reason for that is we would like to utilize HTTP/2 benefits for download style requests if we want to.