Add a global error handler focused on non-route errors #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboulter11
commented
Dec 6, 2024
.swiftpm/xcode/xcshareddata/xcschemes/SwiftyDropbox-Package.xcscheme
Outdated
Show resolved
Hide resolved
jboulter11
commented
Dec 6, 2024
| - SwiftyDropbox (10.0.0) | ||
| - SwiftyDropboxObjC (10.0.0): | ||
| - SwiftyDropbox (~> 10.0.0) | ||
| - SwiftyDropbox (10.1.0) |
There was a problem hiding this comment.
Unclear if we want this?
shaunfowler
reviewed
Dec 9, 2024
shaunfowler
approved these changes
Dec 9, 2024
shaunfowler
reviewed
Dec 9, 2024
| } | ||
| } | ||
|
|
||
| func registerGlobalErrorHandler(_ callback: @escaping (CallError<Any>) -> Void, queue: OperationQueue = .main) { |
There was a problem hiding this comment.
Let’s include a corresponding deregister call to ensure completeness
shaunfowler
requested changes
Dec 9, 2024
Source/SwiftyDropbox/Shared/Handwritten/GlobalErrorResponseHandler.swift
Outdated
Show resolved
Hide resolved
shaunfowler
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds unfair lock utility class which we love in the Dropbox codebase.
Adds global error response handler which type-erases route errors so we can have simple global error handling.
We are adding this due to a need to handle auth error responses globally.
Test Plan
Unit tests, integration tests incoming