Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker image generation in Dockerfile #5

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Fix docker image generation in Dockerfile #5

merged 1 commit into from
Apr 6, 2021

Conversation

gissehel
Copy link

@gissehel gissehel commented Apr 4, 2021

Closes: #4

What are the changes and their implications?

  • There is a new Dockerfile
  • docker-start.sh has been modified to reflect the changes
  • The Dockerfile doesn't use working copy, but use source from https://github.com/droppy-js/droppy
  • The Makefile is able to generate Dockerfile-dev which works like Dockerfile but for working copy

The resulting image has been tested with parametrized UID and GID, and it works as expected.

Checklist

  • Changes covered by tests (tests added if needed)
  • PR submitted to droppy-js.com for any user facing changes

@markhughes
Copy link
Collaborator

Thanks for adjusting that! Appreciate the help!

@markhughes markhughes merged commit f4f8da4 into droppyjs:canary Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile doesn't compile to generate a valid image anymore
2 participants