Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply grammar suggestions from the IntelliJ linter #9469

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

rhowe
Copy link
Contributor

@rhowe rhowe commented Oct 20, 2024

Problem:

IntelliJ's linter identified a few grammatical gremlins

Solution:

Apply most of them

@rhowe rhowe requested a review from a team as a code owner October 20, 2024 19:04
@github-actions github-actions bot added this to the 4.0.10 milestone Oct 20, 2024
@joschi joschi modified the milestones: 4.0.10, 4.0.11 Oct 21, 2024
Copy link
Contributor

@georgespalding georgespalding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, an improvement

Copy link
Contributor

@georgespalding georgespalding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure what the best practice is for this repo, the PR says "out of date with base branch" so perhaps rebase onto release/4.0.x?

Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhowe Thanks! ❤️

@joschi joschi enabled auto-merge (squash) November 25, 2024 22:41
@joschi joschi merged commit 2d11113 into dropwizard:release/4.0.x Nov 25, 2024
10 of 11 checks passed
@rhowe rhowe deleted the grammar-fixups branch November 25, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants