From 32b6037b36e3c81278251a2ca150baab5b27d6d5 Mon Sep 17 00:00:00 2001 From: Mooneer Salem Date: Wed, 24 Jan 2024 21:27:46 -0800 Subject: [PATCH 1/2] Fix bug where PTT button background color doesn't change when toggling PTT via space bar. --- src/ongui.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ongui.cpp b/src/ongui.cpp index eaa108011..0405a3972 100644 --- a/src/ongui.cpp +++ b/src/ongui.cpp @@ -794,13 +794,18 @@ int MainApp::FilterEvent(wxEvent& event) if (frame->m_RxRunning && (mainWindowActive || reporterActiveButNotUpdatingTextMessage) && wxGetApp().appConfiguration.enableSpaceBarForPTT && !frame->isReceiveOnly()) { - // space bar controls rx/rx if keyer not running + // space bar controls tx/rx if keyer not running if (frame->vk_state == VK_IDLE) { if (frame->m_btnTogPTT->GetValue()) frame->m_btnTogPTT->SetValue(false); else frame->m_btnTogPTT->SetValue(true); + // Update background color of button here because when toggling PTT via keyboard, + // the background color for some reason doesn't update inside togglePTT(). + frame->m_btnTogPTT->SetBackgroundColour(frame->m_btnTogPTT->GetValue() ? *wxRED : wxNullColour); + + // Actually toggle PTT. frame->togglePTT(); } else // space bar stops keyer From ce53ceac480eabb15c3f5440749bd36744a8de0c Mon Sep 17 00:00:00 2001 From: Mooneer Salem Date: Wed, 24 Jan 2024 21:29:23 -0800 Subject: [PATCH 2/2] Add PR #669 to changelog. --- USER_MANUAL.md | 1 + 1 file changed, 1 insertion(+) diff --git a/USER_MANUAL.md b/USER_MANUAL.md index e8911d86b..236133c7a 100644 --- a/USER_MANUAL.md +++ b/USER_MANUAL.md @@ -896,6 +896,7 @@ LDPC | Low Density Parity Check Codes - a family of powerful FEC codes * Better handle high sample rate audio devices and those with >2 channels. (PR #668) * Fix issue preventing errors from being displayed for issues involving the FreeDV->Speaker sound device. (PR #668) * Fix issue resulting in incorrect audio device usage after validation failure if no valid default exists. (PR #668) + * Fix bug where PTT button background color doesn't change when toggling PTT via space bar. (PR #669) 2. Enhancements: * Add Frequency column to RX drop-down. (PR #663) * Update tooltip for the free form text field to indicate that it's not covered by FEC. (PR #665)