Improve gamut clamping #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cobalt-ui with
|
| Latest commit: |
effbda2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2451353b.cobalt-ui.pages.dev |
| Branch Preview URL: | https://improve-gamut-clamping.cobalt-ui.pages.dev |
🦋 Changeset detectedLatest commit: effbda2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
improve-gamut-clamping
branch
from
31195ac
to
effbda2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
drwpow
commented
Mar 25, 2024
| @@ -365,10 +369,65 @@ export function convertTokensStudioFormat(rawTokens: Record<string, unknown>): { | |||
| tokenPath, | |||
| ); | |||
| } else { | |||
| let value: string | undefined = v.value; | |||
There was a problem hiding this comment.
This is pretty hacky, but fixes an existing bug where rgba({colors.black}, 0.2) would get left as-is.
Does a little work to fix common scenarios, but is by no means exhaustive and there are still plenty of other broken scenarios I’m sure.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
color.gamutoption that lets you clamp to sRGB or P3 colorspace without rewriting your colors.color.convertToHexwhere it wasn’t properly gamut clamping (hex by definition requires sRGB space; there’s no such thing as P3 hex colors)How to Review