This repository has been archived by the owner on May 22, 2023. It is now read-only.
Issue 27 return empty object on 204 responses #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses drwpow#27 by returning an empty object for 204 responses to avoid json parsing errors while keeping with current conventions for backward compatability.
1 task
drwpow
reviewed
Apr 20, 2023
| expect(response.status).toBe(204); | ||
|
|
||
| // assert error is empty | ||
| expect(error).toBe(undefined); |
This was referenced Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
{}for 204 responsesChanges
This adds a check so that if the response code is 204, then an empty object is returned rather than attempting to parse the missing content. See #27 for further detail
How to Review
A response with a 204 status code and no body will return
{}in the data field. Before the change, this will fail with a JSON parse error.Checklist