Unset Content-Type for FormData as request body before Request() constructor call #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. call. Fixes openapi-ts#1548 content-type header with multipart boundary set by Request() is retained
🦋 Changeset detectedLatest commit: 40ddad6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Great fix, thank you! If you could add a changeset ( |
|
Changeset looks perfect. There’s still a linting issue though; be sure to run |
drwpow
approved these changes
Feb 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Typeheader with multipart boundary set byRequest()is currently stripped after being set sincev0.8.2.Changes
#1548 Requests with FormData bodies are currently failing since
v0.8.2How to Review
Had to alter test case for
Content-Typecheck in case of FormData body.Additional test cases covering
FormDatawith a file Blob would help match'content-type' => 'multipart/form-data; boundary=----formdata-undici-0.6976734701101202'Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)