Support per-key custom errors for array paths #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeusz-niemiec
force-pushed
the
master
branch
6 times, most recently
from
993b98e to
e81c6ad
Compare
Comment on lines
73
to
74
| non_index_keys = [] | ||
| keys.each { |k| non_index_keys << k unless k.is_a?(Numeric) } |
There was a problem hiding this comment.
these two lines are non_index_keys = keys.reject { |k| k.is_a?(Integer) }
There was a problem hiding this comment.
lol, I tried to use filter but it was unavailable in the 2.4 version and I totally forgot about reject, thanks :)
There was a problem hiding this comment.
ruby's version of filter is select which IMO makes more sense because it's not obvious if filter filters in or out
tadeusz-niemiec
force-pushed
the
master
branch
from
e81c6ad to
0df4e1c
Compare
|
Complexity increasing per file
==============================
- lib/dry/validation/messages/resolver.rb 2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #663
This allows using custom errors by a key without an index when used in .each.
I guess there should be a better way to check if this is related to .each than by checking the keys array size, let me know if you have any ideas.