-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for latest dry-configurable setting API #686
Conversation
f332067
to
58ea332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I want to make it work with both versions until 2.0.0. Thoughts?
@solnic good thought, and I think you're right, particularly for the post-1.0 gems of ours. Do you have any thoughts about how to go about it? |
@timriley I did this here 5ff1883 but also did this there 0471911aa95a184f594cfded07f762becad09489 so if we require latest dry-schema here then what I did here won't be needed EDIT 3: fixing link to dry-schema commit 🙄 |
@solnic I like what you did over in |
@timriley yes sorry that's what I meant 🙂 the only "issue" is that we would have to ensure the new dry-validation depends on the new dry-schema too...unless you want to override |
@solnic Yeah, I think we'd want to put this shim directly in every gem that uses such an approach |
4c11707
to
8608f48
Compare
This shouldn't be needed with the improved backwards compatibility expected in dry-configurable 0.13.0
Thanks to the improved backwards compatibility in the upcoming dry-configurable deprecations (tested in dry-rb/dry-configurable#120), this one no longer needed any kind of additional shim. |
No description provided.